add unsafe math optimization error bounds for the non-derived atan2 #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
added
OpenCL C Spec
aharon-abramson
pushed a commit
to aharon-abramson/OpenCL-Docs
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tables describing required accuracy for math functions with "unsafe math optimizations" enabled we describe the required accuracy for both "derived" and "non-derived" implementations for most functions, but not for
atan2.This PR adds the required error bounds for atan2 as <= 8192 ulp, consistent with the required error bounds for the other non-derived implementations.
In addition, for Khronos folks, note that the required error bounds in these cases were originally added by BugZilla 12379. I believe the intent all along was to define non-derived error bounds for
atan2, but in the original proposal document the table cell foratan2wraps onto the next page and it doesn't appear that the non-derived error bounds were ever incorporated into the actual spec.